Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.platformdirs: 3.5.1 -> 3.9.1 #243038

Closed
wants to merge 1 commit into from
Closed

python3Packages.platformdirs: 3.5.1 -> 3.9.1 #243038

wants to merge 1 commit into from

Conversation

kirillrdy
Copy link
Member

@kirillrdy kirillrdy commented Jul 12, 2023 •
edited

Description of changes

fixes #242935
platformdirs/platformdirs@3.5.1...3.9.1

I am still running nixpkgs-review but I feel like it will not finish any time soon

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@kirillrdy kirillrdy marked this pull request as draft July 12, 2023 09:34
@ofborg ofborg bot requested a review from fabaff July 12, 2023 11:26
@kirillrdy kirillrdy marked this pull request as ready for review July 14, 2023 04:32
@kirillrdy kirillrdy marked this pull request as draft July 18, 2023 09:53
@kirillrdy kirillrdy changed the title python3Packages.platformdirs: 3.5.1 -> 3.8.1 python3Packages.platformdirs: 3.5.1 -> 3.9.1 Jul 18, 2023
@kirillrdy kirillrdy marked this pull request as ready for review July 18, 2023 12:11
@SuperSandro2000
Copy link
Member

included in #244135

@kirillrdy kirillrdy deleted the platformdirs branch July 18, 2023 12:19
@kirillrdy
Copy link
Member Author

@SuperSandro2000 its my 100th closed/merged PR ! you win a small prize !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kirillrdy @SuperSandro2000