Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.cryptography: 40.0.1 -> 41.0.1 #238965

Conversation

SuperSandro2000
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@exarkun
Copy link
Contributor

exarkun commented Jul 7, 2023

Can I help move this along somehow?

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jul 7, 2023

Can I help move this along somehow?

Nah, we just need to rebase this.


@ofborg build python310Packages.cryptography python311Packages.cryptography

@exarkun
Copy link
Contributor

exarkun commented Jul 7, 2023

I have now used this to build/test/package a recent version of Tahoe-LAFS against pyOpenSSL 23.2.0 (which requires cryptography >=41, <42). I encountered one new test failure in Twisted (twisted/twisted#11892) which I ended up patching in a skip for (it looks like a test bug to me, but it's also not entirely trivial to make sense of) and I had to upgrade service-identity to 23.1.0 to address an x509 parsing test failure that looks related to cryptography to me. With Twisted and service-identity thus adjusted, I had success with the cryptography in this PR on Python 3.8, Python 3.9, and Python 3.10.

@exarkun
Copy link
Contributor

exarkun commented Jul 7, 2023

I encountered one new test failure in Twisted (twisted/twisted#11892) which I ended up patching in a skip for (it looks like a test bug to me, but it's also not entirely trivial to make sense of)

Upstream confirms this is a bug in Twisted's test suite which has already been fixed (but not released) - twisted/twisted#11878

@SuperSandro2000 SuperSandro2000 added this to In progress in Python batch upgrade via automation Jul 7, 2023
@SuperSandro2000
Copy link
Member Author

depends on #238006

@SuperSandro2000
Copy link
Member Author

Included in #244135

Python batch upgrade automation moved this from In progress to Done Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants