Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.httpx: 0.23.3 -> 0.24.1 #237274

Closed
wants to merge 2 commits into from
Closed

python3Packages.httpx: 0.23.3 -> 0.24.1 #237274

wants to merge 2 commits into from

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jun 12, 2023 •
edited

Description of changes

https://github.com/encode/httpx/blob/master/CHANGELOG.md

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fabaff and costrouc June 12, 2023 03:09
@tjni tjni mentioned this pull request Jun 14, 2023
Merged
12 tasks
@tjni
Copy link
Contributor

tjni commented Jun 14, 2023

Would you mind adding a commit updating pytest-httpx to v0.22.0? It seems intended to move in lockstep with httpx.

This was referenced Jun 14, 2023
Merged
Merged
Closed
Merged
Merged
@tjni
Copy link
Contributor

tjni commented Jun 16, 2023 •
edited

As noted in #238033, frogmouth is also affected and will need its dependency on httpx to be relaxed.

@mweinelt
Copy link
Member

Would you mind adding a commit updating pytest-httpx to v0.22.0? It seems intended to move in lockstep with httpx.

Please also update httpcore for the same reason

@mweinelt mweinelt added this to In progress in Python batch upgrade via automation Jun 18, 2023
@ofborg ofborg bot requested a review from risicle June 18, 2023 12:19
@bhipple
Copy link
Contributor Author

bhipple commented Jun 18, 2023 •
edited

Thank you for pushing this along, @mweinelt! It's much appreciated. I've had a really busy week at work so I haven't had time to follow-up, and probably won't have much this week either.

@bhipple
Copy link
Contributor Author

bhipple commented Jun 18, 2023

I added the relaxed deps on frogmouth as requested.

@ofborg ofborg bot requested a review from figsoda June 18, 2023 16:52
@figsoda
Copy link
Member

figsoda commented Jun 27, 2023

#240135 updates frogmouth with updates its httpx dependency

@bhipple
Copy link
Contributor Author

bhipple commented Jul 3, 2023

I rebased away the changes that have already been merged. I think the rest is now good for review?

dropping b1aeda150799209be82285f9fdf86d291200abbf python310Packages.pytest-httpx: 0.21.3 -> 0.22.0 -- patch contents already upstream
dropping 7a81cb6803390d183924df84f420eded64288ea5 python310Packages.frogmouth: relax dependency on httpx -- patch contents already upstream

@SuperSandro2000
Copy link
Member

included in #244135

Python batch upgrade automation moved this from In progress to Done Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff Awaiting requested review from fabaff

@costrouc costrouc Awaiting requested review from costrouc

@risicle risicle Awaiting requested review from risicle

@figsoda figsoda Awaiting requested review from figsoda

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Python batch upgrade
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bhipple @tjni @mweinelt @figsoda @SuperSandro2000