Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asitop: init at 0.0.23 #233224

Merged
merged 3 commits into from
May 21, 2023
Merged

asitop: init at 0.0.23 #233224

merged 3 commits into from
May 21, 2023

Conversation

juliusrickert
Copy link
Member

@juliusrickert juliusrickert commented May 21, 2023 •
edited

Description of changes

asitop is a Terminal UI (TUI) which provides visualisations for macOS's powermetrics tool.

https://github.com/tlkh/asitop

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This PR adds dashing too, a dependency of asitop.

I successfully ran asitop using nix run .#asitop.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 21, 2023
@juliusrickert juliusrickert marked this pull request as draft May 21, 2023 13:22
@juliusrickert juliusrickert force-pushed the add-asitop branch 2 times, most recently from 5aef987 to 032c4a0 Compare May 21, 2023 13:25
@juliusrickert juliusrickert marked this pull request as ready for review May 21, 2023 13:26
@juliusrickert
Copy link
Member Author

Sorry for the noise. git push --force-with-lease didn't work and threw me off a bit. 😅

@juliusrickert juliusrickert changed the title darwin.asitop: init at 0.0.23 asitop: init at 0.0.23 May 21, 2023
@wegank
Copy link
Member

wegank commented May 21, 2023

Result of nixpkgs-review pr 233224 run on aarch64-darwin 1

4 packages built:
  • asitop
  • asitop.dist
  • python310Packages.dashing
  • python310Packages.dashing.dist

@wegank wegank merged commit 6a60386 into NixOS:master May 21, 2023
24 checks passed
@juliusrickert juliusrickert deleted the add-asitop branch May 21, 2023 17:54
dotlambda
dotlambda reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add pythonImportsCheck.

pkgs/development/python-modules/dashing/default.nix
@@ -0,0 +1,27 @@
{ lib
, python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not okay in pythonPackages. This would use Python 3.10 for python311Packages.dashing. Fixed in #244135

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing that out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@wegank wegank wegank approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juliusrickert @wegank @dotlambda @Janik-Haag