Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: python-babel tests fail when not UTC around Eastern Daylight time #222013

Closed
wants to merge 1 commit into from

Conversation

s1341
Copy link
Contributor

@s1341 s1341 commented Mar 19, 2023

See python-babel/babel#988 on upstream

Description of changes
  • exported TZ=UTC for checkPhase
  • added pytz to nativeCheckInputs
  • disabled the test_format_time test
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 19, 2023

Please follow the contributing guide when naming your commits.


This PR rebuilds a lot of packages which means we must target staging. Please follow the contributing guide to not potentially ping a lot of people.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to add it at runtime if zoneinfo not always works?

https://github.com/python-babel/babel/blob/master/setup.py#L64-L68

@s1341
Copy link
Contributor Author

s1341 commented Mar 20, 2023

Closing as this is already fixed on staging: a9b7d738fc14

@s1341 s1341 closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants