Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off state logging in HostAllocSuite #10615

Merged

Conversation

abellina
Copy link
Collaborator

@abellina abellina commented Mar 20, 2024

Closes #10585

This reverts part of #10590 to turn off again the state logging. In my tests, this logging made the race condition stop happening and so the tests only fail without the logging.

This is waiting for rapidsai/cudf#15351 to be merged and the fix to propagate to spark-rapids-jni.

Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
@abellina abellina added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Mar 20, 2024
@abellina
Copy link
Collaborator Author

build

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abellina abellina marked this pull request as ready for review March 21, 2024 13:30
@abellina
Copy link
Collaborator Author

build

@abellina
Copy link
Collaborator Author

The cuDF PR propagated to spark-rapids-jni.

@abellina abellina removed the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Mar 21, 2024
@abellina
Copy link
Collaborator Author

build

@abellina abellina merged commit 079d0fe into NVIDIA:branch-24.04 Mar 21, 2024
44 checks passed
@abellina abellina deleted the stop_state_logging_in_hostallocsuite branch March 21, 2024 17:49
@sameerz sameerz added the test Only impacts tests label Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Test simple pinned blocking alloc Failed nightly tests
4 participants