Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileTarget: Add option WriteHeaderWhenInitialFileNotEmpty #5407

Merged
merged 9 commits into from Nov 14, 2023
Merged

FileTarget: Add option WriteHeaderWhenInitialFileNotEmpty #5407

merged 9 commits into from Nov 14, 2023

Conversation

RomanSoloweow
Copy link
Contributor

Fix #2119

@welcome Welcome
Copy link

welcome bot commented Nov 13, 2023

Thanks for opening this pull request!
We will try to review this soon! Please note that pull requests with unit tests are earlier accepted 👼

@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 13, 2023
@RomanSoloweow
Copy link
Contributor Author

@304NotModified @snakefoot can you check this PR please?

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 14, 2023
@snakefoot snakefoot changed the title FileTarget: Add WriteHeaderOnStartup parameter. FileTarget: Add option WriteHeaderOnInitialFileOpen Nov 14, 2023
snakefoot
snakefoot approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@snakefoot snakefoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the code is looking good. Thank you the unit-test, and being patient with me and all my nitpicks. Hope the new logic will bring happiness to many :)

@snakefoot snakefoot added this to the 5.2.6 milestone Nov 14, 2023
@RomanSoloweow
Copy link
Contributor Author

Thanks for your review! I hope this really helps users

I understand that I’m in a hurry with this question, but is there any information when a nuget package with this functionality might be released? :)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@RomanSoloweow
Copy link
Contributor Author

RomanSoloweow commented Nov 14, 2023 •
edited

Oh, I got it. November 19th, right?

@snakefoot
Copy link
Contributor

snakefoot commented Nov 14, 2023 •
edited

Yes try to publish patch-version once every month, as long there is something relevant commited.

@snakefoot snakefoot merged commit b0b30df into NLog:dev Nov 14, 2023
5 checks passed
@welcome Welcome
Copy link

welcome bot commented Nov 14, 2023

Hooray your first pull request is merged! Thanks for the contribution! Looking for more? 👼 Please check the up-for-grabs issues - thanks!
thanks!

@snakefoot
Copy link
Contributor

snakefoot commented Nov 14, 2023 •
edited

Updated the wiki - https://github.com/NLog/NLog/wiki/File-target so it matches #5408

@snakefoot snakefoot added needs documentation on wiki documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) labels Nov 14, 2023
@snakefoot snakefoot mentioned this pull request Nov 15, 2023
Merged
@snakefoot snakefoot changed the title FileTarget: Add option WriteHeaderOnInitialFileOpen FileTarget: Add option WriteHeaderWhenInitialFileNotEmpty Nov 18, 2023
@snakefoot
Copy link
Contributor

NLog v5.2.6 has been released - https://www.nuget.org/packages/NLog/5.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snakefoot snakefoot snakefoot approved these changes

Assignees
No one assigned
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) feature file-target needs documentation on wiki size/L
Projects
None yet
Milestone
5.2.6
Development

Successfully merging this pull request may close these issues.

Log header is printed once for each application instance
2 participants
@RomanSoloweow @snakefoot