New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileTarget: Add option WriteHeaderWhenInitialFileNotEmpty #5407
Conversation
Thanks for opening this pull request! |
@304NotModified @snakefoot can you check this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think the code is looking good. Thank you the unit-test, and being patient with me and all my nitpicks. Hope the new logic will bring happiness to many :)
Thanks for your review! I hope this really helps users I understand that I’m in a hurry with this question, but is there any information when a nuget package with this functionality might be released? :) |
Kudos, SonarCloud Quality Gate passed! |
Oh, I got it. November 19th, right? |
Yes try to publish patch-version once every month, as long there is something relevant commited. |
Hooray your first pull request is merged! Thanks for the contribution! Looking for more? 👼 Please check the up-for-grabs issues - thanks! |
Updated the wiki - https://github.com/NLog/NLog/wiki/File-target so it matches #5408 |
NLog v5.2.6 has been released - https://www.nuget.org/packages/NLog/5.2.6 |
Fix #2119