Fixed IncludeActivityIdsWithBeginScope for NET8

NLog · Dec 29, 2023 · 7caa533 · 7caa533
1 parent cfe3e59
commit 7caa533
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/src/NLog.Extensions.Logging/Logging/ActivityExtensions.cs b/src/NLog.Extensions.Logging/Logging/ActivityExtensions.cs
@@ -1,4 +1,4 @@
-#if NET6_0
+#if NET5_0_OR_GREATER
 
 using System.Diagnostics;
 

diff --git a/src/NLog.Extensions.Logging/Logging/NLogBeginScopeParser.cs b/src/NLog.Extensions.Logging/Logging/NLogBeginScopeParser.cs
@@ -94,12 +94,7 @@ public IDisposable ParseBeginScope<T>(T state)
             }
         }
 
-#if !NET6_0
-        private static IReadOnlyList<KeyValuePair<string, object>> IncludeActivityIdsProperties(IReadOnlyList<KeyValuePair<string, object>> scopePropertyList)
-        {
-            return scopePropertyList;   // Not supported
-        }
-#else
+#if NET5_0_OR_GREATER
         private IReadOnlyList<KeyValuePair<string, object>> IncludeActivityIdsProperties(IReadOnlyList<KeyValuePair<string, object>> scopePropertyList)
         {
             if (_options.IncludeActivityIdsWithBeginScope && "RequestId".Equals(scopePropertyList[0].Key))
@@ -162,6 +157,11 @@ IEnumerator IEnumerable.GetEnumerator()
                 return ((IEnumerable)_originalPropertyList).GetEnumerator();
             }
         }
+#else
+        private static IReadOnlyList<KeyValuePair<string, object>> IncludeActivityIdsProperties(IReadOnlyList<KeyValuePair<string, object>> scopePropertyList)
+        {
+            return scopePropertyList;   // Not supported
+        }
 #endif
 
         public static IDisposable CaptureScopeProperties(IEnumerable scopePropertyCollection, ExtractorDictionary stateExtractor)

diff --git a/src/NLog.Extensions.Logging/Logging/NLogProviderOptions.cs b/src/NLog.Extensions.Logging/Logging/NLogProviderOptions.cs
@@ -60,7 +60,7 @@ public class NLogProviderOptions
         /// </summary>
         public bool AutoShutdown { get; set; }
 
-#if NET6_0
+#if NET5_0_OR_GREATER
         /// <summary>
         /// Automatically include <see cref="System.Diagnostics.Activity.SpanId"/>, <see cref="System.Diagnostics.Activity.TraceId"/> and <see cref="System.Diagnostics.Activity.ParentId"/>
         /// </summary>

diff --git a/test/NLog.Extensions.Logging.Tests/Extensions/ConfigureExtensionsTests.cs b/test/NLog.Extensions.Logging.Tests/Extensions/ConfigureExtensionsTests.cs
@@ -57,7 +57,7 @@ public void AddNLog_LoggerFactory_LogInfoWithEventId_ShouldLogToNLogWithEventId(
             AssertSingleMessage(memoryTarget, $"{expectedEventInLog} - test message with 1 arg");
         }
 
-#if NET6_0
+#if NET6_0_OR_GREATER
         [Fact]
         public void AddNLog_LoggerFactory_IncludeActivityIdsWithBeginScope()
         {