[TASK] Drop PHP_CodeSniffer #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
task/drop-codesniffer
branch
from
daa3ad0
to
282cf37
Compare
This tool is not well-maintained anymore, and it has no PER2 coding standard, which is a blocker for us moving to PER2. PHP-CS-Fixer already has a PER2 coding standard. If we use PHP-CS-Fixer on PER2 and PHP_CodeSniffer on PSR12 (the latest available standard there), both tools would keep overwriting each other's changes endlessly, and they would never agree on the correct formatting.
oliverklee
force-pushed
the
task/drop-codesniffer
branch
from
282cf37
to
2168b8e
Compare
sabberworm
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
I agree we shouldn’t use two tools for the same job.
I just wanted to point out that the project, much like this one, has recently moved to a new org (see squizlabs/PHP_CodeSniffer#3932) and there seems to be lots of activity as well as an open issue for PER-2 (PHPCSStandards/PHP_CodeSniffer#29).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool is not well-maintained anymore, and it has no PER2 coding standard, which is a blocker for us moving to PER2.
PHP-CS-Fixer already has a PER2 coding standard. If we use PHP-CS-Fixer on PER2 and PHP_CodeSniffer on PSR12 (the latest available standard there), both tools would keep overwriting each other's changes endlessly, and they would never agree on the correct formatting.