-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #6661: Moved content writing from Flush to new method FinalizeContent #8266
base: develop
Are you sure you want to change the base?
Conversation
Note for maintainers: tests must be run against this PR. |
/// <summary> | ||
/// Clears buffer using BinaryWriter's flush method | ||
/// </summary> | ||
public override void Flush() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this anymore? If it's defaulting to the virtual base
call anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all it's doing is calling the base, then it's not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can certainly go and delete it if it's only calling base and has no other purpose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted! Apologies for the delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a maintainer so you would need to ping @harry-cpp / @mrhelmut to review the PR(s).
Flush called base.Flush() exclusively, no longer needed
Solution for Issue #6661
Moves the previous code writing content in Flush() to new method FinalizeContent() and calls it in ContentCompiler method Compile() before calling Flush().