minor refactor in dmverity-vhd tool #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `errors` package instead of the `github.com/pkg/errors`. `createVHD` accepts layer number to avoid calling `layer.DiffID()` twice. Signed-off-by: Maksim An <maksiman@microsoft.com>
helsaawy
approved these changes
Oct 26, 2023
anmaxvl
added a commit
to anmaxvl/hcsshim
that referenced
this pull request
Oct 27, 2023
Use `errors` package instead of the `github.com/pkg/errors`. `createVHD` accepts layer number to avoid calling `layer.DiffID()` twice. Signed-off-by: Maksim An <maksiman@microsoft.com> (cherry picked from commit a3be979)
anmaxvl
added a commit
that referenced
this pull request
Oct 30, 2023
Use `errors` package instead of the `github.com/pkg/errors`. `createVHD` accepts layer number to avoid calling `layer.DiffID()` twice. Signed-off-by: Maksim An <maksiman@microsoft.com> (cherry picked from commit a3be979)
darracott
pushed a commit
to KenGordon/hcsshim
that referenced
this pull request
Oct 30, 2023
Use `errors` package instead of the `github.com/pkg/errors`. `createVHD` accepts layer number to avoid calling `layer.DiffID()` twice. Signed-off-by: Maksim An <maksiman@microsoft.com> Signed-off-by: Joe Powell <joepowell@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
errorspackage instead of thegithub.com/pkg/errors.createVHDaccepts layer number to avoid callinglayer.DiffID()twice.