Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync RunVSTestTask task params #540

Merged
merged 1 commit into from Mar 8, 2024
Merged

Sync RunVSTestTask task params #540

merged 1 commit into from Mar 8, 2024

Conversation

dfederm
Copy link
Member

@dfederm dfederm commented Mar 7, 2024

Sync RunVSTestTask task params

Seeing this when I simply PackageReference Microsoft.Build.RunVSTest and run msbuild /t:Build;Test:

D:\Code\.nuget\microsoft.build.runvstest\1.0.312-gef8f11a7a1\build\Microsoft.Build.RunVSTest.targets(10,3): error MSB4044: The "RunVSTestTask" task was not given a value for the required parameter "VSTestRunnerVersion".

VSTestRunnerVersion is a Required param but isn't used at all.

This change synchronizes the params in the task and in the targets file so they're aligned.

AndyGerlicher
AndyGerlicher previously approved these changes Mar 7, 2024
@dfederm dfederm merged commit fe8bb08 into main Mar 8, 2024
5 checks passed
@dfederm dfederm deleted the fix-runvstesttask branch March 8, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants