-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
Builds ready [7b30a4a]
|
Builds ready [e8b19a5]
|
e8b19a5
to
393fa7f
Compare
'!.prettierrc.js', | ||
'dist/', | ||
'storybook-static/', | ||
], | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to add storybook static folder otherwise linting was failing
Builds ready [393fa7f]
|
393fa7f
to
de69cdc
Compare
Builds ready [de69cdc]
|
@@ -60,7 +60,7 @@ | |||
"eslint-plugin-jsdoc": "^36.1.0", | |||
"eslint-plugin-node": "^11.1.0", | |||
"eslint-plugin-prettier": "^3.3.1", | |||
"eslint-plugin-storybook": "^0.5.6", | |||
"eslint-plugin-storybook": "^0.6.3", | |||
"jest": "^26.4.2", | |||
"node-fetch": "^2.6.0", | |||
"prettier": "^2.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating packages and using prettier to change scripts to alphabetical order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
'!.eslintrc.js', | ||
'!.prettierrc.js', | ||
'dist/', | ||
'storybook-static/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding storybook-static/ directory to ignore linting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Upgrading storybook from
^6.4.18
to^6.5.10
because it includes a bunch of goodies.Manual testing steps
yarn setup && yarn storybook
References
https://storybook.js.org/blog/storybook-6-5/#webpack-5-lazy-compilation-for-faster-startup