Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Upgrading storybook to 6.5 #212

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Upgrading storybook to 6.5 #212

merged 2 commits into from
Aug 8, 2022

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented Aug 5, 2022

Description

Upgrading storybook from ^6.4.18 to ^6.5.10 because it includes a bunch of goodies.

Manual testing steps

  • Check out the storybook build from this PR or pull this branch and run yarn setup && yarn storybook
  • Check that stories and docs still work as usual

References

https://storybook.js.org/blog/storybook-6-5/#webpack-5-lazy-compilation-for-faster-startup

Screen Shot 2022-08-05 at 10 46 33 AM

Verified

This commit was signed with the committer’s verified signature.
georgewrmarshall George Marshall
@georgewrmarshall georgewrmarshall added the code Issue related to code work label Aug 5, 2022
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner August 5, 2022 17:47
@georgewrmarshall georgewrmarshall changed the title Updating storybook Updating storybook to 6.5 Aug 5, 2022
@georgewrmarshall georgewrmarshall self-assigned this Aug 5, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [7b30a4a]

@georgewrmarshall georgewrmarshall changed the title Updating storybook to 6.5 Upgrading storybook to 6.5 Aug 5, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [e8b19a5]

'!.prettierrc.js',
'dist/',
'storybook-static/',
],
};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to add storybook static folder otherwise linting was failing

@metamaskbot
Copy link
Collaborator

Builds ready [393fa7f]

Verified

This commit was signed with the committer’s verified signature.
georgewrmarshall George Marshall
@metamaskbot
Copy link
Collaborator

Builds ready [de69cdc]

@@ -60,7 +60,7 @@
"eslint-plugin-jsdoc": "^36.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^3.3.1",
"eslint-plugin-storybook": "^0.5.6",
"eslint-plugin-storybook": "^0.6.3",
"jest": "^26.4.2",
"node-fetch": "^2.6.0",
"prettier": "^2.2.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating packages and using prettier to change scripts to alphabetical order

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

'!.eslintrc.js',
'!.prettierrc.js',
'dist/',
'storybook-static/',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding storybook-static/ directory to ignore linting

Copy link
Collaborator

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@georgewrmarshall georgewrmarshall merged commit 3e89161 into main Aug 8, 2022
@georgewrmarshall georgewrmarshall deleted the updating-storybook branch August 8, 2022 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code Issue related to code work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants