Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "wallet_swapAsset v1" #289

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Feb 26, 2025

Reverts #201 due to wallet_swapAsset not being live yet.

This reverts commit 7296916.
@alexandratran alexandratran requested a review from a team as a code owner February 26, 2025 04:27
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently causing the e2e tests in MetaMask/metamask-extension#27782 to fail, so it would be great to revert this if this is indeed not ready.

Copy link
Contributor

@vandan vandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as well. I assume we can find this snippet to add back when the method is ready.

@alexandratran alexandratran merged commit 7907227 into main Mar 1, 2025
8 checks passed
@alexandratran alexandratran deleted the revert-201-wallet_swapAsset branch March 1, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants