Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aborting a pipe with preventCancel = true #119

Merged
merged 9 commits into from
May 24, 2022
Merged

Fix aborting a pipe with preventCancel = true #119

merged 9 commits into from
May 24, 2022

Conversation

MattiasBuelens
Copy link
Owner

Some of the changes in #99 broke preventCancel. This fixes that.

Fixes #118.

@MattiasBuelens MattiasBuelens added bug domain: compliance Issues related to compliance with the streams standard labels May 23, 2022
@MattiasBuelens MattiasBuelens added this to the v4.0.0-beta.3 milestone May 23, 2022
@MattiasBuelens MattiasBuelens self-assigned this May 23, 2022
@MattiasBuelens MattiasBuelens force-pushed the fix-abort-pipe-with-prevent-cancel branch from 9a928d7 to a20d082 Compare May 23, 2022 22:36
@MattiasBuelens MattiasBuelens merged commit 18529d0 into next May 24, 2022
@MattiasBuelens MattiasBuelens deleted the fix-abort-pipe-with-prevent-cancel branch May 24, 2022 19:38
MattiasBuelens added a commit that referenced this pull request Nov 9, 2022
@MattiasBuelens
Revert "Merge pull request #119 from MattiasBuelens/fix-abort-pipe-wi…
b0757b3 
…th-prevent-cancel"

This reverts commit 18529d0, reversing
changes made to f6ed190.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MattiasBuelens MattiasBuelens

Labels
bug domain: compliance Issues related to compliance with the streams standard
Projects
None yet
Milestone
v4.0.0-beta.3
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MattiasBuelens