Add fallback for package exports #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This increases the final package size... slightly. As noted in #83 (comment), these extra |
|
@MattiasBuelens Could you please release another beta version with this? I'm currently using TypeScript nightly to test my library against the new Node.js ESM format. Also microsoft/TypeScript#48555 had removed the nightly-only flag so it should be shipped with TypeScript 4.7-beta in days. |
|
@yume-chan I'm going to do a bit more polishing in #113, and then I'll publish a new beta. Thank you for your patience. 🙂 |
|
Released as v4.0.0-beta.2. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #83, we switched to using package entry points for the different variants. Unfortunately, TypeScript 4.5 doesn't yet support this: support has been deferred to a future release. This prevents TypeScript users from importing a polyfill variant, which is not great.
This PR adds a fallback to also provide the variants like we did in version 3, i.e. with "sub packages" (e.g.
es5/package.json). Modern versions of Node and modern bundlers will still pick up the new package entry points. However, tools that don't support this feature yet (like older Node versions and TypeScript 4.5) will instead find the sub packages and resolve the variant that way.