fix/rename-authenticatordevice-type #625
Merged
+87
−87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the @simplewebauthn/types
AuthenticatorDevice
type toWebAuthnCredential
.AuthenticatorDevice.credentialID
andAuthenticatorDevice.credentialPublicKey
have been shortened toWebAuthnCredential.id
andWebAuthnCredential.publicKey
respectively.@simplewebauthn/server's
verifyRegistrationResponse()
has been updated to return a newcredential
value of typeWebAuthnCredential
. The oldcredentialID
,credentialPublicKey
, andcounter
values have been replaced bycredential.id
,credential.publicKey
, andcredential.counter
respectively.The
authenticator
argument in @simplewebauthn/server'sverifyAuthenticationResponse()
has also been renamed tocredential
of typeWebAuthnCredential
.Fixes #558.
Breaking Changes - verifyRegistrationResponse()
Update code that stores
credentialID
,credentialPublicKey
, andcounter
out ofverifyRegistrationResponse()
to storecredential.id
,credential.publicKey
, andcredential.counter
instead:Before:
After:
Breaking Changes - verifyAuthenticationResponse()
Update calls to
verifyAuthenticationResponse()
to match the newcredential
argument that replaces theauthenticator
argument:Before:
After: