Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template CI workflow: do not run codecov coverage in CRON CI #58

Merged
merged 8 commits into from May 19, 2023

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented May 12, 2023

Fixes #54

Changes made in this Pull Request:

  • add condition on running codecov to exclude CRON CI

PR Checklist

  • n/a Tests?
  • n/a Docs?
  • CHANGELOG.md updated?
  • AUTHORS.md updated?
  • Issue raised/referenced?

@orbeckst
Copy link
Member Author

Have to figure out how to protect && for the templating

FAILED tests/test_output.py::test_write_outputs[n-DependencyType.CONDAFORGE] - jinja2.exceptions.TemplateSyntaxError: unexpected char '&' at 3799

@orbeckst
Copy link
Member Author

Removing the unnecessary expression syntax ${{ ... }} in if: avoided having to worry about to quote ${{ ... }} for the jinja templating.

Still failing, although I don't understand (yet) why.

Also fails due to #56.

@orbeckst
Copy link
Member Author

The error in actions "Error: Job 'main-tests' failed" and looking at the 10,000 lines of output does not reveal to me where the problem is.

@lilyminium @IAlibay @ianmkenney would you mind having a look?

@orbeckst
Copy link
Member Author

Who knows, maybe it's just codecov ... and cycling the PR magically fixes things?

Btw, how are the differently numbered tests "GH Actions CI/main-tests-1", ..., "GH Actions CI/main-tests-12" generated and what do they do — are they different entries in the OS test matrix? I couldn't figure it out by looking at workflows and tests/ and in particular I don't understand what is really failing because each section says "success". There seem to be codecov upload errors (which still count as success) so that's why I am just pushing another silly commit.

@lilyminium
Copy link
Member

Sorry for the delay, was pretty swamped with OMSF stuff.

About the numbered tests -- yes sorry, I think you're referring to the cookie matrix of tests failing (since the cookie tests a matrix of settings). I usually comment them out if I have to debug something but it shows up very messily in the act output. I'll have a proper look when I get my laptop back tomorrow (eastern) morning.

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @orbeckst!

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @orbeckst!

@lilyminium lilyminium merged commit cfd89d6 into main May 19, 2023
12 checks passed
@lilyminium lilyminium deleted the ci-no-coverage-cron branch May 19, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codecov upload limits cause failing CI
2 participants