New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template CI workflow: do not run codecov coverage in CRON CI #58
Conversation
Have to figure out how to protect
|
b8d1a1c
to
7a63c55
Compare
Removing the unnecessary expression syntax Still failing, although I don't understand (yet) why. Also fails due to #56. |
The error in actions "Error: Job 'main-tests' failed" and looking at the 10,000 lines of output does not reveal to me where the problem is. @lilyminium @IAlibay @ianmkenney would you mind having a look? |
Who knows, maybe it's just codecov ... and cycling the PR magically fixes things? Btw, how are the differently numbered tests "GH Actions CI/main-tests-1", ..., "GH Actions CI/main-tests-12" generated and what do they do — are they different entries in the OS test matrix? I couldn't figure it out by looking at workflows and tests/ and in particular I don't understand what is really failing because each section says "success". There seem to be codecov upload errors (which still count as success) so that's why I am just pushing another silly commit. |
Sorry for the delay, was pretty swamped with OMSF stuff. About the numbered tests -- yes sorry, I think you're referring to the cookie matrix of tests failing (since the cookie tests a matrix of settings). I usually comment them out if I have to debug something but it shows up very messily in the act output. I'll have a proper look when I get my laptop back tomorrow (eastern) morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thank you @orbeckst!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thank you @orbeckst!
Fixes #54
Changes made in this Pull Request:
PR Checklist