OSOE-675: Set StopOnFail option to true un xunit.runner.json for Lombiq.OSOCE.Tests.UI #612
Conversation
…sts.UI with StopOnFail set to true
github-actions
bot
changed the title
| "$schema": "https://xunit.net/schema/current/xunit.runner.schema.json", | ||
| "parallelizeAssembly": false, | ||
| "parallelizeTestCollections": true, | ||
| "maxParallelThreads": 3, |
There was a problem hiding this comment.
Based on this code: https://github.com/Lombiq/GitHub-Actions/blob/dev/.github/actions/test-dotnet/Set-XUnitMaxParallelThreads.ps1#L21-L34
it will use the xunit.runner.json's value. Which is not good since we are overriding it here: https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/blob/dev/.github/workflows/build-and-test.yml#L20
There was a problem hiding this comment.
@DemeSzabolcs Should it just be to get rid of maxParallelThreads?
There was a problem hiding this comment.
I think that would be the simplest, yes.
There was a problem hiding this comment.
Sorry @DemeSzabolcs, I think I messed up with this PR.
I just closed it and open this other one: #616
|
@tteguayco Please also create an OSOCE PR with the submodule changes. |
|
Hey @DemeSzabolcs Isn't this the OSOCE PR? Also, it looks like |
|
@tteguayco Oh so sorry. For some reason I thought this was in the UI testing submodule. All good, ignore that comment. |
OSOE-675
This configuration file is ignored when running the tests directly from VisualStudio.
It takes the configuration file into consideration when running the tests via
dotnet test.A related issue was opened: xunit/visualstudio.xunit#392