This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Rayon support #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to hold off on merging this for now so I can evaluate if In the meantime, I'm open to reviews from others. |
The times to beat: stackblur_1024 ... bench: 18,514,600 ns/iter (+/- 3,095,887) stackblur_128 ... bench: 11,743,780 ns/iter (+/- 2,533,038) stackblur_16 ... bench: 11,109,190 ns/iter (+/- 1,912,941) Non-parallel version of `stackblur-iter`: blur_srgb_1024 ... bench: 17,162,590 ns/iter (+/- 3,337,943) blur_srgb_128 ... bench: 14,260,590 ns/iter (+/- 2,214,481) blur_srgb_16 ... bench: 13,107,140 ns/iter (+/- 2,408,900) New parallel version (with 12 threads): par_blur_srgb_1024 ... bench: 4,309,255 ns/iter (+/- 352,918) par_blur_srgb_128 ... bench: 3,979,880 ns/iter (+/- 305,431) par_blur_srgb_16 ... bench: 4,063,585 ns/iter (+/- 310,803)
Merged
|
Merged as part of #6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made changes in
imgref-iterto make this possible.Behold:
Fixes #3