Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding requirements parser #107

Merged
merged 7 commits into from Mar 1, 2023
Merged

adding requirements parser #107

merged 7 commits into from Mar 1, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 17, 2023

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

porting Lightning-AI/pytorch-lightning#13912
so we can use it also in other projects like TM

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the enhancement New feature or request label Feb 17, 2023
@Borda Borda requested a review from carmocca February 20, 2023 14:43
@Borda Borda enabled auto-merge (squash) February 20, 2023 22:41
@Borda
Copy link
Member Author

Borda commented Mar 1, 2023

porting fix from: Lightning-AI/torchmetrics#1572

@Borda Borda requested a review from carmocca March 1, 2023 13:38
@Borda Borda merged commit 09e25a3 into main Mar 1, 2023
@Borda Borda deleted the requiremnts branch March 1, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants