Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent metric dtype conversion when metric is part of LightningModule #1583

Merged
merged 17 commits into from Mar 7, 2023
Merged

Prevent metric dtype conversion when metric is part of LightningModule #1583

merged 17 commits into from Mar 7, 2023

Commits on Mar 3, 2023

  1. Added check in Metric._apply() to stop dtype conversions on metric st… 

    …ates and defaults
    @FarzanT
    FarzanT committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    ac9520d View commit details
    Browse the repository at this point in the history

  2. Updated docstring

    @FarzanT
    FarzanT committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    257eb46 View commit details
    Browse the repository at this point in the history

  3. Unit test for metric state dtype change in LightningModule

    @FarzanT
    FarzanT committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    48e38cf View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1 from FarzanT/state_dtype 

    Prevent dtype conversion of metric states in LightningModule
    @FarzanT
    FarzanT committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    be01593 View commit details
    Browse the repository at this point in the history

  5. Formatting fix with pre-commit

    @FarzanT
    FarzanT committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    b85df2a View commit details
    Browse the repository at this point in the history

  6. Merge pull request #2 from FarzanT/state_dtype 

    Formatting fix with pre-commit
    @FarzanT
    FarzanT committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    70e52a6 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2023

  1. Merge branch 'master' into master

    @SkafteNicki
    SkafteNicki committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    5deeb73 View commit details
    Browse the repository at this point in the history

  2. changelog

    @SkafteNicki
    SkafteNicki committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    dcd0a86 View commit details
    Browse the repository at this point in the history

  3. add more cases

    @SkafteNicki
    SkafteNicki committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    6aa9ffd View commit details
    Browse the repository at this point in the history

  4. fix cases

    @SkafteNicki
    SkafteNicki committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    1e35301 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Merge branch 'master' into master

    @Borda
    Borda committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    91e108d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into master

    @SkafteNicki
    SkafteNicki committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    48fe9db View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into master

    @Borda
    Borda committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    63021b0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into master

    @Borda
    Borda committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    0087877 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into master

    @Borda
    Borda committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    1986bd2 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Merge branch 'master' into master

    @mergify
    mergify[bot] committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    3ce033c View commit details
    Browse the repository at this point in the history

  2. Update tests/unittests/bases/test_metric.py

    @SkafteNicki
    SkafteNicki committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    cfee14a View commit details
    Browse the repository at this point in the history