Add type check on maximize in MetricTracker
#1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test case to `test_raises_error_on_wrong_input` to check that the initialization of a MetricTracker with a single `metric` and a list `maximize` raises a ValueError
* Add check on maximize to be a singe bool when the metric is a single Metric
ValerianRey
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton and
ethanwharris
as code owners
ValerianRey
changed the title
maximize in MetricTracker
Borda
approved these changes
Jan 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1430 +/- ##
========================================
- Coverage 90% 38% -52%
========================================
Files 211 211
Lines 10844 10846 +2
========================================
- Hits 9714 4124 -5590
- Misses 1130 6722 +5592 |
SkafteNicki
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1428
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Yes!