Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: fix skip links #1572

Merged
merged 6 commits into from Feb 28, 2023
Merged

pkg: fix skip links #1572

merged 6 commits into from Feb 28, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 28, 2023

What does this PR do?

Published packages can't have web links
https://github.com/Lightning-AI/metrics/actions/runs/4294267269/jobs/7483067345
fixes #1571 leaked from: #1512

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug / fix Something isn't working Priority Critical task/issue labels Feb 28, 2023
@Borda Borda requested review from justusschock, stancld and a team February 28, 2023 18:46
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1572 (13c11be) into master (0713dcb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1572   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files         223     223           
  Lines       11656   11656           
======================================
  Hits        10310   10310           
  Misses       1346    1346           

@mergify mergify bot added the ready label Feb 28, 2023
@Borda Borda enabled auto-merge (squash) February 28, 2023 20:40
@Borda Borda merged commit 50388cf into master Feb 28, 2023
@Borda Borda deleted the pkg/release branch February 28, 2023 21:43
Borda added a commit that referenced this pull request Mar 10, 2023
(cherry picked from commit 50388cf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working Priority Critical task/issue ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.11.2 and 0.11.3 not released on PyPI
3 participants