feat: make aggregate id an interface #566
Conversation
It seems that phpunit has a problem with trait approach, we do the same in our services and it works fine 🤔 |
src/UuidAggregateIdTrait.php
Outdated
|
|
||
| public function equals(AggregateId $other): bool | ||
| { | ||
| return $this->uuid->toString() === $other->toString(); |
There was a problem hiding this comment.
| return $this->uuid->toString() === $other->toString(); | |
| return $this->uuid->equals($other->uuid); |
There was a problem hiding this comment.
Alternatively
| return $this->uuid->toString() === $other->toString(); | |
| return $other instanceof $this && $this->uuid->equals($other->uuid); |
But this comes down to semantics of if FooId and BarId with the same underlying UUID are equal? I would say they are not.
There was a problem hiding this comment.
I'm not sure if I can easily make use of equals.
Check is done from trait, so I can't have access to field, we have to expose uuid instance on the interface to make it work?.
There was a problem hiding this comment.
Like this:
91d6c6b
There was a problem hiding this comment.
As the trait is mixed in to the actual class it has full private member access of other instances of the same type, so it works for me (tests pass) with this change locally:
public function equals(AggregateId $other): bool
{
return $other instanceof $this
&& $this->uuid->equals($other->uuid);
}So we can drop exposing toUuid() unless I'm missing something?
There was a problem hiding this comment.
I was sure that phpstan had a problem that make sense yesterday, but maybe I something else was wrong 🤔
Passes now, happy to change
Probably just the |
|
|
No description provided.