feat(LLD): Update modelListId with unique device type #3766
+19
β17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
This property must be updated for the time being, as it is not possible to uniquely identify the connection of a new or old device.
Each time a Nano is connected, the list is expanded. So you could end up with 45 NanoXs when in fact it's potentially the same device 45 times over. The result is erroneous and potentially very misleading analytics.
To resolve this problem, we need to find a way, like LLM, to have a unique identifier for the Nano. So there's a dependency on the Device team on this subject.
Now if my user has 3 nanoX, 1 Stax and 2 NanoS
the list will be: [ "nanoX", "stax", "nanoS"]
β Context
LLD
β Checklist
πΈ Demo
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.