feat(LLD): Update modelListId with unique device type #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately this PR does not comply with the Contributing Conventions and will be closed automatically.Feel free to reopen this PR once you have browsed through the guidelines. Found Issues:
|
|
| Name | Type |
|---|---|
| ledger-live-desktop | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cgrellard-ledger
approved these changes
Jun 21, 2023
mcayuelas-ledger
force-pushed
the
feat/model-list-id-lld
branch
from
29f102e
to
3d1f79c
Compare
hedi-edelbloute
pushed a commit
that referenced
this pull request
Jun 21, 2023
* feat(LLD): Update modelListId with unique device type * Update Changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This property must be updated for the time being, as it is not possible to uniquely identify the connection of a new or old device.
Each time a Nano is connected, the list is expanded. So you could end up with 45 NanoXs when in fact it's potentially the same device 45 times over. The result is erroneous and potentially very misleading analytics.
To resolve this problem, we need to find a way, like LLM, to have a unique identifier for the Nano. So there's a dependency on the Device team on this subject.
Now if my user has 3 nanoX, 1 Stax and 2 NanoS
the list will be: [ "nanoX", "stax", "nanoS"]
❓ Context
LLD✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.