Set outlineStyle instead of outline when preventing outline
#8917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
force-pushed
the
fix-safari-outline
branch
from
1890f41
to
4af605a
Compare
Falke-Design
approved these changes
Apr 12, 2023
|
Yes, I tested this manually in the latest versions of Chrome, Firefox and Safari. They all seem to have the expected behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the implementation of
preventOutline()andrestoreOutline()so thatoutline-styleis set rather than the wholeoutlineproperty. This seems to prevent a regression introduced in Safari 16.4, and remains functional in other browsers.Closes #8908