Bugfix: Fix noMoveStart option for fitBounds method #8911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be awesome if we could bring this adjustment into the next release. |
AbdullahSohail-SE
changed the title
|
We need to check if the docs needs to be updated. https://leafletjs.com/reference.html#zoom-options |
|
The docs describe the noMoveStart as inherit from panning. But it didn't worked before. |
|
@veitbjarsch seconded, cc: @Falke-Design |
|
@Falke-Design any updates? |
|
@mourner @jonkoops @IvanSanchez any chance to get this into the next release? Would love to use it. |
jonkoops
approved these changes
May 16, 2023
Co-authored-by: Jon Koops <jonkoops@gmail.com>
Falke-Design
requested changes
May 18, 2023
Falke-Design
approved these changes
May 18, 2023
Falke-Design
added a commit
that referenced
this pull request
May 18, 2023
Co-authored-by: Jon Koops <jonkoops@gmail.com> Co-authored-by: Florian Bischof <design.falke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation overrides the noMoveStart option to false value.