Fix kotlinx-coroutines-debug having the wrong module-info #3948
Conversation
dkhalanskyjb
force-pushed
the
dk-remove-debug-module-info
branch
from
c93bdc0
to
13f969f
Compare
| /* `kotlinx-coroutines-debug` configures `VersionFile` on its own when the corresponding task is created. */ | ||
| val invalidModules = listOf("kotlinx-coroutines-debug") | ||
|
|
||
| configure(subprojects.filter { |
There was a problem hiding this comment.
Configuring subproject is usually a bad sign.
Instead, you should probably add this configuration logic to your convention plugin, and apply the convention plugin to all relevant subprojects using the plugins block.
Gradle recommend that approach as it allow more optimisations. Also, more clarity.
See that part of the docs.
You are already using a convention plugin, you just need to use it fully. (I can detail if you need)
There was a problem hiding this comment.
Thank you, the Archangel. The wisdom of this advice is indisputable. Yet our land is too full of sin to be ready for such a revelation. The project is ripe with the filthy touch of subproject iteration, and making one place holy will but incite more chaos. The whole city must be burned to crisps before it rises as a temple (if you catch my meaning).
Though if you have quick access to some specific links to the required reading, sure, please share them. Maybe I'm wrong, and this could conveniently be done one iteration over subprojects at a time, then there's no reason not to do that.
There was a problem hiding this comment.
Hahahahaha.
I did not look into details yet, I may not have time today, but maybe if I'm bored this weekend, we never know!
But indeed, feel free to ignore my comment for now, it was mainly informative and we probably should nuke all of these cross-configuration at once.
dkhalanskyjb
force-pushed
the
dk-remove-debug-module-info
branch
from
554d99b
to
7521130
Compare
dkhalanskyjb
force-pushed
the
dk-remove-debug-module-info
branch
3 times, most recently
from
4c0cbd1
to
82152a6
Compare
|
Using advice from @shanshin, I redid the whole approach to just pack the |
| VersionFile.fromVersionFile(this, versionFileTask) | ||
| duplicatesStrategy = DuplicatesStrategy.FAIL | ||
| dependsOn(tasks.compileModuleInfoJava) | ||
| doLast { |
There was a problem hiding this comment.
Thumbs up for the new approach, it's much more straightforward now
dkhalanskyjb
force-pushed
the
dk-remove-debug-module-info
branch
2 times, most recently
from
48ad741
to
d5e8cbb
Compare
This module-info taken from bytebuddy was incorrectly picked up as the module info for `kotlinx-coroutines-debug`
Also try to fix the shadow jar being published
Co-authored-by: Vsevolod Tolstopyatov <qwwdfsad@gmail.com>
Co-authored-by: Titouan BION <titouan.bion@gmail.com>
Co-authored-by: Titouan BION <titouan.bion@gmail.com>
Co-authored-by: Titouan BION <titouan.bion@gmail.com>
dkhalanskyjb
force-pushed
the
dk-remove-debug-module-info
branch
from
d5e8cbb
to
afa50d0
Compare
|
Good to go, great job! |
Fixes #3944