Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross module resolution local links #3425

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Fix cross module resolution local links #3425

merged 6 commits into from
Jan 11, 2024

Commits on Mar 2, 2023

  1. all-modules-page: Validate cross-module links during resolution 

    The existing behavior was just taking the first module that includes the
package name of a given reference, so this resulted in broken links when
a package is split across multiple modules.

This change checks to ensure the resolved file exists before choosing it
as the target for the resolved link.

Signed-off-by: Eddie Ringle <eddie@ringle.io>
    @EddieRingle
    EddieRingle committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    d728849 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Merge remote-tracking branch 'origin' into er/mmp-cross-module-resolu… 

    …tion-fix
    @vmishenev
    vmishenev committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    af9a5b2 View commit details
    Browse the repository at this point in the history

  2. Check links only if resolved links has more than one link

    @vmishenev
    vmishenev committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    7dad81c View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Add integration test

    @vmishenev
    vmishenev committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d738a09 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Refactor

    @vmishenev
    vmishenev committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    0a830ae View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Add comment

    @vmishenev
    vmishenev committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    32933c7 View commit details
    Browse the repository at this point in the history