Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kotlinx.html to 0.9.1 #3206

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Bump kotlinx.html to 0.9.1 #3206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ intellij-platform = "213.7172.25"
jsoup = "1.15.3"
freemarker = "2.3.31"
soywiz-korte = "2.7.0"
kotlinx-html = "0.7.5"
kotlinx-html = "0.9.1"

## Markdown
jetbrains-markdown = "0.3.1"
Expand Down
1 change: 0 additions & 1 deletion plugins/base/api/base.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,6 @@ public final class org/jetbrains/dokka/base/renderers/html/command/consumers/Imm
public fun onTagContentEntity (Lkotlinx/html/Entities;)V
public fun onTagContentUnsafe (Lkotlin/jvm/functions/Function1;)V
public fun onTagEnd (Lkotlinx/html/Tag;)V
public fun onTagError (Lkotlinx/html/Tag;Ljava/lang/Throwable;)V
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the reason why it was removed (see Kotlin/kotlinx.html#224), but everything works, soo hopefully it wasn't used :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onTagError implies that every visit* should do try-finally section which is kind of bytecode-heavy.

With heavy tag usages it, AFAIR, bloated bytecode

public fun onTagEvent (Lkotlinx/html/Tag;Ljava/lang/String;Lkotlin/jvm/functions/Function1;)V
public fun onTagStart (Lkotlinx/html/Tag;)V
public final fun processCommand (Lorg/jetbrains/dokka/base/templating/Command;Lkotlin/jvm/functions/Function1;)V
Expand Down