Refactor publishing configuration #3030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-⚠️ rename `dokka_publication_channel`, `dokka_publication_channels` to `org.jetbrains.dokka.publicationChannels` - add `publicationChannels` do `DokkaBuildProperties` - refactor `registerDokkaArtifactPublication()` helper - add docs to `ValidatePublications` task - moving `dokka_build` val to `DokkaBuildProperties`, but don't start updating usages yet - refactor `projectsWithoutOptInDependency` to be more generic - migrate `ValidatePublications` checks into `maven-publish.gradle.kts` (which is just a messy first draft and could use with a re-write) Additional changes: - move integration test properties (parallelism and exhaustive) into DokkaBuildProperties - re-write 'disable DokkaHtml for MavenLocal' check
aSemy
commented
Jun 4, 2023
Comment on lines
90
to
94
| afterEvaluate { // Workaround for an interesting design choice https://github.com/gradle/gradle/blob/c4f935f77377f1783f70ec05381c8182b3ade3ea/subprojects/plugin-development/src/main/java/org/gradle/plugin/devel/plugins/MavenPluginPublishPlugin.java#L49 | ||
| configureSpacePublicationIfNecessary("pluginMaven", "dokkaGradlePluginPluginMarkerMaven") | ||
| configureSonatypePublicationIfNecessary("pluginMaven", "dokkaGradlePluginPluginMarkerMaven") | ||
| createDokkaPublishTaskIfNecessary() | ||
| // configureSpacePublicationIfNecessary("pluginMaven", "dokkaGradlePluginPluginMarkerMaven") | ||
| // configureSonatypePublicationIfNecessary("pluginMaven", "dokkaGradlePluginPluginMarkerMaven") | ||
| // createDokkaPublishTaskIfNecessary() | ||
| } |
There was a problem hiding this comment.
I'm not quite sure if the changes I've made are equivalent to this existing config, and it's difficult to check without actually publishing.
…ing_build_config # Conflicts: # build-logic/src/main/kotlin/org/jetbrains/ValidatePublications.kt # build-logic/src/main/kotlin/org/jetbrains/conventions/dokka.gradle.kts # docs-developer/build.gradle.kts # kotlin-analysis/build.gradle.kts # kotlin-analysis/compiler-dependency/build.gradle.kts # kotlin-analysis/intellij-dependency/build.gradle.kts
|
I believe this PR can be closed, as the publishing setup is changed? @adam-enko ? |
Yes, agreed, the refactoring was mostly completed as part of #3132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an infrastructureEverything related to builds tools, CI configurations and project tooling
issue, part of #2703, specifically this comment
This PR is larger than I intended, I started picking things apart and I couldn't stop! I think it's worth having it all in one place so you can have a general overview, but just give me the word and I'll split out anything worth investigating into a separate PR.
I've done some preliminary tests using
./gradlew publishAllPublicationsToSpaceDokkaDevRepository --dry-run, but of course this isn't a real-life scenario.Summary
dokka_publication_channel,dokka_publication_channelstoorg.jetbrains.dokka.publicationChannels, so the properties are consistentpublicationChannelsdoDokkaBuildProperties, so it's more easily accessibleregisterDokkaArtifactPublication()helperValidatePublicationstaskdokka_buildval toDokkaBuildProperties, but don't start updating usages yetprojectsWithoutOptInDependencyto be more genericValidatePublicationschecks intomaven-publish.gradle.kts(which is just a messy first draft and could use with a re-write)Additional changes: