Skip to content

Sort class signatures before dump the same way KotlinApiBuildTask does #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

fzhinkin
Copy link
Collaborator

@fzhinkin fzhinkin commented Feb 5, 2024

Currently, there is an API dumping class signatures, but its behavior differs slightly from what the Gradle task does.

This PR fixes the behavior and reuses the API inside the Gradle task.

Closes #178

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@aSemy
Copy link
Contributor

aSemy commented Feb 15, 2024

Hi @fzhinkin, I've checked and this issue would resolve #178. Please merge and release when possible, thanks!

@fzhinkin fzhinkin linked an issue Feb 16, 2024 that may be closed by this pull request
@fzhinkin fzhinkin marked this pull request as ready for review February 16, 2024 08:03
@fzhinkin fzhinkin requested review from ilya-g and qwwdfsad February 16, 2024 08:03
@fzhinkin fzhinkin merged commit 4ff0aac into develop Feb 19, 2024
@fzhinkin fzhinkin deleted the sort-class-signatures-before-dumping branch February 19, 2024 12:49
Copy link
Member

@ilya-g ilya-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I've checked that it does not affect the dump in stdlib, probably because the classes were already sorted on loading in loadApiFromJvmClasses.

shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Oct 28, 2024
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 3, 2024
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BCV-MU requires access to ClassBinarySignature properties
4 participants