Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): use constants for referencing images and ports #4088

Merged
merged 2 commits into from
May 26, 2023

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented May 26, 2023

What this PR does / why we need it:

Initial refactor - do not use magic strings and numbers to refer images and their ports used in tests.

Which issue this PR fixes:

This is a part of implementing e2e tests that verifies proper handling of EndpointSlices #4026

Special notes for your reviewer:

This is the part of implementing strategy proposed in this one too big PR #4084.

In test/integration/tlsroute_test.go:765 const tlsEchoPort and its usage is a little bit mysterious to me. I backchannelled it to the author to gain more understanding (and maybe handle in different PR).

Labelled with ci/run-e2e to be sure, result has to be examined.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@programmer04 programmer04 added area/tests area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. ci/run-e2e Trigger e2e test run from PR labels May 26, 2023
@programmer04 programmer04 added this to the KIC v2.10.0 milestone May 26, 2023
@programmer04 programmer04 self-assigned this May 26, 2023
@programmer04 programmer04 requested a review from a team as a code owner May 26, 2023 10:59
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5090073830

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label May 26, 2023
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 26, 2023 11:04 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 26, 2023 11:04 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 26, 2023 11:04 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 26, 2023 11:04 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 26, 2023 11:04 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 26, 2023 11:04 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 26, 2023 11:04 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.1 ⚠️

Comparison is base (753e91f) 60.0% compared to head (931b591) 60.0%.

❗ Current head 931b591 differs from pull request most recent head 8b1f91f. Consider uploading reports for the commit 8b1f91f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4088     +/-   ##
=======================================
- Coverage   60.0%   60.0%   -0.1%     
=======================================
  Files        151     151             
  Lines      16612   16612             
=======================================
- Hits        9982    9981      -1     
- Misses      5999    6000      +1     
  Partials     631     631             

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@programmer04
Copy link
Member Author

For ci/run-e2e on GKE image that does not include #4071 (from yesterday was used, thus GKE results are ignored. For Kind everything is 🟢

@programmer04 programmer04 enabled auto-merge (squash) May 26, 2023 12:27
test/consts.go Outdated Show resolved Hide resolved
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
@programmer04 programmer04 merged commit cb51bb9 into main May 26, 2023
26 checks passed
@programmer04 programmer04 deleted the e2e-refactor branch May 26, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants