-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests): use constants for referencing images and ports #4088
Conversation
E2E (targeted) tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5090073830 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4088 +/- ##
=======================================
- Coverage 60.0% 60.0% -0.1%
=======================================
Files 151 151
Lines 16612 16612
=======================================
- Hits 9982 9981 -1
- Misses 5999 6000 +1
Partials 631 631 ☔ View full report in Codecov by Sentry. |
For |
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
What this PR does / why we need it:
Initial refactor - do not use magic strings and numbers to refer images and their ports used in tests.
Which issue this PR fixes:
This is a part of implementing e2e tests that verifies proper handling of EndpointSlices #4026
Special notes for your reviewer:
This is the part of implementing strategy proposed in this one too big PR #4084.
In
test/integration/tlsroute_test.go:765
consttlsEchoPort
and its usage is a little bit mysterious to me. I backchannelled it to the author to gain more understanding (and maybe handle in different PR).Labelled with
ci/run-e2e
to be sure, result has to be examined.PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR