Overhaul CDash integration with CI #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
cdash-build-names-and-groups
branch
from
b7cb33f
to
58da77c
Compare
zackgalbreath
previously approved these changes
Mar 29, 2024
williamjallen
force-pushed
the
cdash-build-names-and-groups
branch
from
ac69187
to
f344ed8
Compare
|
Failing tests were due to CMake version being too old. I made substantial enough changes that it would probably be a good idea for @zackgalbreath to take another look. |
zackgalbreath
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2095 switched our CI provider from CircleCI to GitHub Actions, but broke our integration with CDash.
The checkout action provided by GitHub runs workflows triggered by the
pull_requestevent against a merge commit instead of the PR's head ref. This causes issues with the CDash integration since the git hash CDash receives does not match the most recent hash on the pull request. I was not able to resolve the callback issue, but the changes in this PR improve the CDash build name being submitted, and assign runs to appropriate build groups.I plan to take another look at this issue at a future point to restore our CDash callback.