-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove interactive-graph-locked-features-labels flag #2063
Conversation
…flag
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (df418e1) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2063 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2063 |
Size Change: -167 B (-0.01%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoohoo! Love seeing the code clean-up. Reminder to hold off on landing to main until after the holidays. ❤️
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@49.2.1 ### Patch Changes - [#2064](#2064) [`55b4615d3`](55b4615) Thanks [@nishasy](https://github.com/nishasy)! - Remove the locked-figures-aria flag - [#2063](#2063) [`85a5b5e44`](85a5b5e) Thanks [@nishasy](https://github.com/nishasy)! - Remove the interactive-graph-locked-features-labels flag - [#2078](#2078) [`781cc7df6`](781cc7d) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Temporarily fixing pi-based strings for Numeric Input - [#2065](#2065) [`eefcf5c5c`](eefcf5c) Thanks [@nishasy](https://github.com/nishasy)! - Remove the locked-[figureName]-labels flags - [#2068](#2068) [`265a93104`](265a931) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Redesign discriminated union type parser to have a simpler and more intuitive interface. - [#2073](#2073) [`4bf4960d4`](4bf4960) Thanks [@benchristel](https://github.com/benchristel)! - Internal: improve Perseus JSON parsers so they can handle all English-language exercises - [#2080](#2080) [`c9a28b34c`](c9a28b3) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Dropdown] Bugfix - Text in dropdown not in correct vertical position - [#2073](#2073) [`4bf4960d4`](4bf4960) Thanks [@benchristel](https://github.com/benchristel)! - Internal: improve the error messages produced by the versionedWidgetOptions parser ## @khanacademy/perseus-editor@17.1.1 ### Patch Changes - [#2064](#2064) [`55b4615d3`](55b4615) Thanks [@nishasy](https://github.com/nishasy)! - Remove the locked-figures-aria flag - [#2063](#2063) [`85a5b5e44`](85a5b5e) Thanks [@nishasy](https://github.com/nishasy)! - Remove the interactive-graph-locked-features-labels flag - [#2065](#2065) [`eefcf5c5c`](eefcf5c) Thanks [@nishasy](https://github.com/nishasy)! - Remove the locked-[figureName]-labels flags - Updated dependencies \[[`55b4615d3`](55b4615), [`85a5b5e44`](85a5b5e), [`781cc7df6`](781cc7d), [`eefcf5c5c`](eefcf5c), [`265a93104`](265a931), [`4bf4960d4`](4bf4960), [`c9a28b34c`](c9a28b3), [`4bf4960d4`](4bf4960)]: - @khanacademy/perseus@49.2.1
Summary:
Remove the
interactive-graph-locked-feature-label
flag from the Perseusrepo now that the full graph aria label/description and standalone locked
labels have been out for a while now.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2274
Test plan:
yarn jest