Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pre-release WB that deletes the ID stuff #2022

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

somewhatabstract
Copy link
Member

Summary:

This updates Perseus to a version of Wonder Blocks where the custom ID generation API has been deleted.

This is going to be released just after the WB release, then webapp will be updated with both and deployed.

Issue: WB-1812

Test plan:

yarn typecheck
yarn lint

@somewhatabstract somewhatabstract self-assigned this Dec 17, 2024
@somewhatabstract somewhatabstract requested a review from a team December 17, 2024 19:48
Copy link
Contributor

github-actions bot commented Dec 17, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (be0bff8) and published it to npm. You
can install it using the tag PR2022.

Example:

yarn add @khanacademy/perseus@PR2022

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2022

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Size Change: 0 B

Total Size: 1.27 MB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 688 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 416 kB
packages/perseus/dist/es/strings.js 4.11 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

Copy link
Contributor

@handeyeco handeyeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeff!

@somewhatabstract somewhatabstract merged commit 266d240 into main Dec 17, 2024
8 checks passed
@somewhatabstract somewhatabstract deleted the wb1812.3.deleting branch December 17, 2024 23:45
somewhatabstract added a commit that referenced this pull request Dec 18, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @khanacademy/math-input@22.0.1

### Patch Changes

- [#2022](#2022)
[`266d240ed`](266d240)
Thanks [@somewhatabstract](https://github.com/somewhatabstract)! -
Update to Wonder Blocks without custom ID generation API

## @khanacademy/perseus@49.0.2

### Patch Changes

- [#2017](#2017)
[`4508e7bea`](4508e7b)
Thanks [@nishasy](https://github.com/nishasy)! - [SR] Minor improvements
to Circle graph SR strings


- [#2022](#2022)
[`266d240ed`](266d240)
Thanks [@somewhatabstract](https://github.com/somewhatabstract)! -
Update to Wonder Blocks without custom ID generation API


- [#2018](#2018)
[`1fe437079`](1fe4370)
Thanks [@catandthemachines](https://github.com/catandthemachines)! -
Fixing scoring for unlimited point to ensure there 1 or more points for
it to be considered scorable.

- Updated dependencies
\[[`266d240ed`](266d240)]:
    -   @khanacademy/math-input@22.0.1

## @khanacademy/perseus-editor@17.0.2

### Patch Changes

- [#2022](#2022)
[`266d240ed`](266d240)
Thanks [@somewhatabstract](https://github.com/somewhatabstract)! -
Update to Wonder Blocks without custom ID generation API

- Updated dependencies
\[[`4508e7bea`](4508e7b),
[`266d240ed`](266d240),
[`1fe437079`](1fe4370)]:
    -   @khanacademy/perseus@49.0.2
    -   @khanacademy/math-input@22.0.1

## @khanacademy/perseus-dev-ui@5.0.2

### Patch Changes

- [#2022](#2022)
[`266d240ed`](266d240)
Thanks [@somewhatabstract](https://github.com/somewhatabstract)! -
Update to Wonder Blocks without custom ID generation API

- Updated dependencies
\[[`266d240ed`](266d240)]:
    -   @khanacademy/math-input@22.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants