-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to pre-release WB that deletes the ID stuff #2022
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (be0bff8) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2022 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2022 |
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
anakaren-rojas
approved these changes
Dec 17, 2024
handeyeco
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jeff!
Merged
somewhatabstract
added a commit
that referenced
this pull request
Dec 18, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/math-input@22.0.1 ### Patch Changes - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API ## @khanacademy/perseus@49.0.2 ### Patch Changes - [#2017](#2017) [`4508e7bea`](4508e7b) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Minor improvements to Circle graph SR strings - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API - [#2018](#2018) [`1fe437079`](1fe4370) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing scoring for unlimited point to ensure there 1 or more points for it to be considered scorable. - Updated dependencies \[[`266d240ed`](266d240)]: - @khanacademy/math-input@22.0.1 ## @khanacademy/perseus-editor@17.0.2 ### Patch Changes - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API - Updated dependencies \[[`4508e7bea`](4508e7b), [`266d240ed`](266d240), [`1fe437079`](1fe4370)]: - @khanacademy/perseus@49.0.2 - @khanacademy/math-input@22.0.1 ## @khanacademy/perseus-dev-ui@5.0.2 ### Patch Changes - [#2022](#2022) [`266d240ed`](266d240) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Update to Wonder Blocks without custom ID generation API - Updated dependencies \[[`266d240ed`](266d240)]: - @khanacademy/math-input@22.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This updates Perseus to a version of Wonder Blocks where the custom ID generation API has been deleted.
This is going to be released just after the WB release, then webapp will be updated with both and deployed.
Issue: WB-1812
Test plan:
yarn typecheck
yarn lint