Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move useVideo to v2 deps #1793

Merged
merged 3 commits into from
Nov 4, 2024
Merged

move useVideo to v2 deps #1793

merged 3 commits into from
Nov 4, 2024

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Oct 24, 2024

Summary:

Experimenting porting v1 Perseus dependencies to v2 Perseus dependencies. Starting with useVideo because its use isn't very widespread.

Test plan:

Nothing should change, just moving where we add useVideo

@handeyeco handeyeco self-assigned this Oct 24, 2024
@khan-actions-bot khan-actions-bot requested a review from a team October 24, 2024 16:59
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Oct 24, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/fuzzy-teachers-scream.md, testing/test-dependencies.tsx, packages/perseus/src/dependencies.ts, packages/perseus/src/types.ts, packages/perseus-editor/src/multirenderer-editor.tsx, packages/perseus/src/__tests__/widget-container.test.tsx, packages/perseus/src/widgets/video/video-transcript-link.test.tsx, packages/perseus/src/widgets/video/video-transcript-link.tsx, packages/perseus/src/widgets/video/video.test.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Size Change: +23 B (0%)

Total Size: 859 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 282 kB -6 B (0%)
packages/perseus/dist/es/index.js 410 kB +29 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.8 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.8 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.54 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Oct 24, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (9b98add) and published it to npm. You
can install it using the tag PR1793.

Example:

yarn add @khanacademy/perseus@PR1793

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1793

@handeyeco handeyeco merged commit 486e4cd into main Nov 4, 2024
9 checks passed
@handeyeco handeyeco deleted the v2deps-usevideo branch November 4, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants