Issue checkstyle#13809: kill mutation for AuditEventDefaultFormatter

Kevin222004 · Oct 4, 2023 · 1da8d2b · 1da8d2b
1 parent a7fa83a
commit 1da8d2b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 45 deletions.
diff --git a/config/pitest-suppressions/pitest-common-suppressions.xml b/config/pitest-suppressions/pitest-common-suppressions.xml
@@ -1,32 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <suppressedMutations>
-  <mutation unstable="false">
-    <sourceFile>AuditEventDefaultFormatter.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.AuditEventDefaultFormatter</mutatedClass>
-    <mutatedMethod>format</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
-    <description>removed call to com/puppycrawl/tools/checkstyle/AuditEventDefaultFormatter::calculateBufferLength</description>
-    <lineContent>final int bufLen = calculateBufferLength(event, severityLevelName.length());</lineContent>
-  </mutation>
-
-  <mutation unstable="false">
-    <sourceFile>AuditEventDefaultFormatter.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.AuditEventDefaultFormatter</mutatedClass>
-    <mutatedMethod>format</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
-    <description>removed call to java/lang/String::length</description>
-    <lineContent>final int bufLen = calculateBufferLength(event, severityLevelName.length());</lineContent>
-  </mutation>
-
-  <mutation unstable="false">
-    <sourceFile>AuditEventDefaultFormatter.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.AuditEventDefaultFormatter</mutatedClass>
-    <mutatedMethod>format</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
-    <description>replaced call to com/puppycrawl/tools/checkstyle/AuditEventDefaultFormatter::calculateBufferLength with argument</description>
-    <lineContent>final int bufLen = calculateBufferLength(event, severityLevelName.length());</lineContent>
-  </mutation>
-
   <mutation unstable="false">
     <sourceFile>Checker.java</sourceFile>
     <mutatedClass>com.puppycrawl.tools.checkstyle.Checker</mutatedClass>

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/AuditEventDefaultFormatter.java b/src/main/java/com/puppycrawl/tools/checkstyle/AuditEventDefaultFormatter.java
@@ -55,9 +55,7 @@ public String format(AuditEvent event) {
             severityLevelName = severityLevel.getName().toUpperCase(Locale.US);
         }
 
-        // Avoid StringBuffer.expandCapacity
-        final int bufLen = calculateBufferLength(event, severityLevelName.length());
-        final StringBuilder sb = new StringBuilder(bufLen);
+        final StringBuilder sb = new StringBuilder();
 
         sb.append('[').append(severityLevelName).append("] ")
             .append(fileName).append(':').append(event.getLine());
@@ -77,21 +75,6 @@ public String format(AuditEvent event) {
         return sb.toString();
     }
 
-    /**
-     * Returns the length of the buffer for StringBuilder.
-     * bufferLength = fileNameLength + messageLength + lengthOfAllSeparators +
-     * + severityNameLength + checkNameLength.
-     *
-     * @param event audit event.
-     * @param severityLevelNameLength length of severity level name.
-     * @return the length of the buffer for StringBuilder.
-     */
-    private static int calculateBufferLength(AuditEvent event, int severityLevelNameLength) {
-        return LENGTH_OF_ALL_SEPARATORS + event.getFileName().length()
-            + event.getMessage().length() + severityLevelNameLength
-            + getCheckShortName(event).length();
-    }
-
     /**
      * Returns check name without 'Check' suffix.
      *