Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #345

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Release #345

merged 5 commits into from
Dec 1, 2023

Conversation

Keats
Copy link
Owner

@Keats Keats commented Nov 7, 2023

No description provided.

@Keats Keats mentioned this pull request Nov 7, 2023
@Keats
Copy link
Owner Author

Keats commented Nov 7, 2023

I'll remove the CI and work on wasm support in another release

@lpotthast
Copy link
Contributor

@Keats This commit alone d4f3300 would be enough for me to work on an and release a "working" 0.1 release of https://github.com/lpotthast/leptos-keycloak-auth. In its current state, this library would only be usable with a git or path dependency, as jsonwebtoken 9.1.0 hat the problem mentioned in your commit. Other that that, jsonwebtoken builds and runs fine for me in wasm! Would appreciate a release which incorporates your commit.
One downside of the ring dependecy is the requirement to install certain additional packages to allow non-failing builds, like clang on linux, llvm on mac, ... with confusing error messages if you dont.

@Keats
Copy link
Owner Author

Keats commented Nov 16, 2023

Other that that, jsonwebtoken builds and runs fine for me in wasm!

Can you easily write a GH action CI test? My attempt in the commit in this PR failed but I don't really know anything about wasm tbh. I'll merge it either way, it just would be nice to know if it works reliably for wasm...

@lpotthast
Copy link
Contributor

Hey @Keats, gave it a shot at #346. Feel free to change anything. Would be nice if you could change the GitHub action so that all dependencies for the wasm-pack call are met (namely, nodejs and wasm-pack being available). Have very little knowledge about GitHub actions and the dtolnay stuff you are using there.

@Keats
Copy link
Owner Author

Keats commented Nov 20, 2023

Yep i'll add it, thanks for the PR!

lpotthast and others added 2 commits December 1, 2023 09:05
* Add wasm tests using was-bindgen-test and wasm-pack

* Remove custom wasm feature

* Add #[wasm_bindgen_test] to remaining tests

* Try to fix CI

---------

Co-authored-by: Vincent Prouillet <github@vincentprouillet.com>
@Keats Keats merged commit 08601f7 into master Dec 1, 2023
6 checks passed
@Keats Keats deleted the release branch December 1, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants