Skip to content

refactor!: remove kilt dependencies from config package #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

refactor!: remove kilt dependencies from config package #763

merged 1 commit into from
Jun 1, 2023
+8 −20

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Jun 1, 2023 •
edited
Loading

Removes unnecessary imports on the config package to make sure we don't add additional cjs imports in an esm context.

How to test:

Test sporran bundle size with this.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

Sorry, something went wrong.

@rflechtner rflechtner changed the base branch from develop to releas-0.33.0 June 1, 2023 13:12
@rflechtner rflechtner changed the base branch from releas-0.33.0 to develop June 1, 2023 13:12
@rflechtner rflechtner force-pushed the rf-remove-deps-from-config branch from b232fb3 to 2fa6840 Compare June 1, 2023 13:14
arty-name
arty-name approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@arty-name arty-name left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s see the effect of this

@rflechtner rflechtner merged commit 5befa74 into develop Jun 1, 2023
@rflechtner rflechtner deleted the rf-remove-deps-from-config branch June 1, 2023 16:02
rflechtner added a commit that referenced this pull request Jun 1, 2023
@rflechtner
refactor: remove kilt dependencies from config package (#763)
3f29145
@rflechtner rflechtner changed the title refactor: remove kilt dependencies from config package refactor!: remove kilt dependencies from config package Jun 7, 2023
@rflechtner rflechtner mentioned this pull request Jun 8, 2023
Merged
rflechtner added a commit that referenced this pull request Jul 26, 2023
@rflechtner
refactor: remove kilt dependencies from config package (#763)
fe3863f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arty-name arty-name

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rflechtner @arty-name