Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump LLVM to include additional patch. #54515

Merged
merged 2 commits into from
May 20, 2024
Merged

Bump LLVM to include additional patch. #54515

merged 2 commits into from
May 20, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented May 18, 2024

Specifically, llvm/llvm-project#91334, which LLVM.jl needs to use the internalize pass on NewPM.

@maleadt maleadt added the external dependencies Involves LLVM, OpenBLAS, or other linked libraries label May 18, 2024
@giordano
Copy link
Contributor

I think you need to update the tools like clang and lld?

@maleadt maleadt marked this pull request as draft May 19, 2024 08:00
@maleadt
Copy link
Member Author

maleadt commented May 19, 2024

I think you need to update the tools like clang and lld?

I didn't rebuild those, only LLVM_full/LLVM_asserts_full and libLLVM_jll. Are you saying we should rebuild those as well? The patch included here does extend the pass pipeline syntax that you can use with opt or clang, but in practice it won't matter (as it will only be used by LLVM.jl via libLLVM).

@giordano
Copy link
Contributor

I believe the standard procedure is to rebuild all llvm-related packages to keep consistent numbers anyway. @gbaraldi @vchuravy can you please clarify the process?

@gbaraldi
Copy link
Member

We usually rebuild everything yes

@maleadt maleadt marked this pull request as ready for review May 20, 2024 09:53
@vchuravy vchuravy merged commit c8a47d6 into master May 20, 2024
7 checks passed
@vchuravy vchuravy deleted the tb/llvm branch May 20, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants