forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expect material3.ModalBottomSheet
in common
#794
Merged
Merged
+446
−362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
Sep 7, 2023
...aterial3/material3/src/skikoMain/kotlin/androidx/compose/material3/ModalBottomSheet.skiko.kt
Outdated
Show resolved
Hide resolved
m-sasha
approved these changes
Sep 11, 2023
a721167
to
1c05d15
Compare
igordmn
approved these changes
Sep 11, 2023
MatkovIvan
added a commit
that referenced
this pull request
Sep 26, 2023
igordmn
pushed a commit
that referenced
this pull request
Nov 15, 2023
* Expect ModalBottomSheet in common * Add ModalBottomSheet3Sample sample * Move everything except Popup to common
igordmn
pushed a commit
that referenced
this pull request
Nov 16, 2023
…` in common (#794) * Expect ModalBottomSheet in common * Add ModalBottomSheet3Sample sample * Move everything except Popup to common
igordmn
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Expect ModalBottomSheet in common * Add ModalBottomSheet3Sample sample * Move everything except Popup to common
MatkovIvan
added a commit
that referenced
this pull request
May 15, 2024
It's upstreaming of #794. This API is already available from common since Compose Multiplatform 1.5.10 Test: N/A Relnote: Make `ModalBottomSheet` available from common source set Change-Id: Id7cc733003fc7c2cdceb95a30b6d7183d39fdffc
copybara-service bot
pushed a commit
to androidx/androidx
that referenced
this pull request
May 16, 2024
It's upstreaming of JetBrains#794. This API is already available from common since Compose Multiplatform 1.5.10 Test: N/A Relnote: Make `ModalBottomSheet` available from common source set Change-Id: Id7cc733003fc7c2cdceb95a30b6d7183d39fdffc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ModalBottomSheet
in common and implement for skikoAPI Changes
Testing
Test: Try to use
ModalBottomSheet
from common or look at mpp demoIssues Fixed
JetBrains/compose-multiplatform#3528