Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variant name interpolation in documentation for IsVariant #360

Merged
merged 1 commit into from
May 25, 2024
Merged

Fix variant name interpolation in documentation for IsVariant #360

merged 1 commit into from
May 25, 2024

Conversation

alpha-tango-kilo
Copy link
Contributor

@alpha-tango-kilo alpha-tango-kilo commented May 19, 2024 •
edited

Resolves #357

Synopsis

Generated documentation is incorrect, see issue

Solution

Ensure stringify! happens after quote! interpolation

Checklist

  • Documentation is updated (if required)
  • Tests are added/updated (if required)
  • CHANGELOG entry is added (if required)

Something for consideration: https://matklad.github.io/2022/10/24/actions-permissions.html

JelteF
JelteF approved these changes May 25, 2024
View reviewed changes
Copy link
Owner

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix. This was quite a silly bug. I don't think it's needed to add tests for this (seems hard to do for little gain).

@JelteF JelteF merged commit f5a9199 into JelteF:master May 25, 2024
17 checks passed
@alpha-tango-kilo alpha-tango-kilo deleted the is-variant-documentation branch May 25, 2024 11:05
@tyranron tyranron added the docs label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelteF JelteF JelteF approved these changes

Assignees

@alpha-tango-kilo alpha-tango-kilo

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IsVariant fails to interpolate variant names in documentation
3 participants
@alpha-tango-kilo @JelteF @tyranron