-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiValue key - made more unique by adding a hyphen #4731
Conversation
🦋 Changeset detectedLatest commit: 59cdba8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 59cdba8:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have exactly this issue with a select box with values "-12" … "+12". "-11" and "-1" collide with keys "-111".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - thanks @sgadman
The key for MultiValue in Select.tsx is not unique enough and can have some edge cases where there are duplicated keys.
For example, if the value is 32 and the index is 6 and another value is 3 and the index is 26. In that case both keys will be 326.
I propose we just add a hyphen between the value and the index. That way the keys will be
32-6
and3-26
in this instance.