Upgrade Node for security #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickmccurdy
force-pushed
the
upgrade-node
branch
from
16bb6a5
to
ee12261
Compare
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #1437 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 7 7
Lines 286 286
Branches 77 77
=======================================
Hits 280 280
Misses 6 6 ☔ View full report in Codecov by Sentry. |
|
Thank you! |
renovate bot
added a commit
to SAP/ui5-webcomponents-react
that referenced
this pull request
Nov 28, 2023
….5.0 (#5288) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [JamesIves/github-pages-deploy-action](https://togithub.com/JamesIves/github-pages-deploy-action) | action | minor | `v4.4.3` -> `v4.5.0` | --- ### Release Notes <details> <summary>JamesIves/github-pages-deploy-action (JamesIves/github-pages-deploy-action)</summary> ### [`v4.5.0`](https://togithub.com/JamesIves/github-pages-deploy-action/releases/tag/v4.5.0) [Compare Source](https://togithub.com/JamesIves/github-pages-deploy-action/compare/v4.4.3...v4.5.0) #### What's Changed - The action is now built and run on Node 20. - Bump [@​types/node](https://togithub.com/types/node) from 20.4.1 to 20.4.2 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1399 - Bump eslint-plugin-jest from 27.2.2 to 27.2.3 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1400 - Bump word-wrap from 1.2.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1401 - Bump eslint-config-prettier from 8.8.0 to 8.9.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1405 - Bump [@​types/node](https://togithub.com/types/node) from 20.4.2 to 20.4.9 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1413 - Bump eslint-config-prettier from 8.9.0 to 9.0.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1410 - Upgrade Node for security by [@​nickmccurdy](https://togithub.com/nickmccurdy) in [JamesIves/github-pages-deploy-action#1437 - doc: `.gitignore` matches not being deployed by [@​sgasse](https://togithub.com/sgasse) in [JamesIves/github-pages-deploy-action#1459 - build(deps): bump actions/setup-node from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1467 - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 20.4.9 to 20.9.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1474 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1429 - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 20.9.0 to 20.10.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1479 #### New Contributors - [@​sgasse](https://togithub.com/sgasse) made their first contribution in [JamesIves/github-pages-deploy-action#1459 **Full Changelog**: JamesIves/github-pages-deploy-action@v4.4.3...v4.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SAP/ui5-webcomponents-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
SebastianGoeb
pushed a commit
to SebastianGoeb/chinese-chart
that referenced
this pull request
Dec 10, 2023
….5.0 (#14) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [JamesIves/github-pages-deploy-action](https://togithub.com/JamesIves/github-pages-deploy-action) | action | minor | `v4.4.1` -> `v4.5.0` | --- ### Release Notes <details> <summary>JamesIves/github-pages-deploy-action (JamesIves/github-pages-deploy-action)</summary> ### [`v4.5.0`](https://togithub.com/JamesIves/github-pages-deploy-action/releases/tag/v4.5.0) [Compare Source](https://togithub.com/JamesIves/github-pages-deploy-action/compare/v4.4.3...v4.5.0) #### What's Changed - The action is now built and run on Node 20. - Bump [@​types/node](https://togithub.com/types/node) from 20.4.1 to 20.4.2 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1399 - Bump eslint-plugin-jest from 27.2.2 to 27.2.3 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1400 - Bump word-wrap from 1.2.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1401 - Bump eslint-config-prettier from 8.8.0 to 8.9.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1405 - Bump [@​types/node](https://togithub.com/types/node) from 20.4.2 to 20.4.9 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1413 - Bump eslint-config-prettier from 8.9.0 to 9.0.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1410 - Upgrade Node for security by [@​nickmccurdy](https://togithub.com/nickmccurdy) in [JamesIves/github-pages-deploy-action#1437 - doc: `.gitignore` matches not being deployed by [@​sgasse](https://togithub.com/sgasse) in [JamesIves/github-pages-deploy-action#1459 - build(deps): bump actions/setup-node from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1467 - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 20.4.9 to 20.9.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1474 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1429 - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 20.9.0 to 20.10.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1479 #### New Contributors - [@​sgasse](https://togithub.com/sgasse) made their first contribution in [JamesIves/github-pages-deploy-action#1459 **Full Changelog**: JamesIves/github-pages-deploy-action@v4.4.3...v4.5.0 ### [`v4.4.3`](https://togithub.com/JamesIves/github-pages-deploy-action/releases/tag/v4.4.3) [Compare Source](https://togithub.com/JamesIves/github-pages-deploy-action/compare/v4.4.2...v4.4.3) #### What's Changed - Bump [@​types/node](https://togithub.com/types/node) from 18.8.0 to 18.8.4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1239 - Bump webfactory/ssh-agent from 0.5.4 to 0.7.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1252 - Bump [@​types/node](https://togithub.com/types/node) from 18.8.4 to 18.11.9 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1262 - Bump eslint-plugin-jest from 27.0.4 to 27.1.5 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1268 - Bump [@​types/node](https://togithub.com/types/node) from 18.11.9 to 18.11.10 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1276 - Bump [@​types/node](https://togithub.com/types/node) from 18.11.10 to 18.11.13 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1283 - Bump eslint-config-prettier from 8.5.0 to 8.6.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1293 - Bump json5 from 2.1.1 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1294 - Bump minimatch from 3.0.4 to 3.1.2 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1270 - Bump decode-uri-component from 0.2.0 to 0.2.2 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1277 - Bump typescript from 4.8.4 to 4.9.4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1281 - Bump eslint-plugin-jest from 27.1.5 to 27.2.1 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1296 - Bump rimraf from 3.0.2 to 4.1.2 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1307 - Bump typescript from 4.9.4 to 4.9.5 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1311 - Bump codecov/codecov-action from 3.1.1 to 3.1.2 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1353 - Bump [@​types/node](https://togithub.com/types/node) from 18.11.13 to 18.16.3 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1361 - Bump codecov/codecov-action from 3.1.2 to 3.1.4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1372 - Bump [@​actions/io](https://togithub.com/actions/io) from 1.1.2 to 1.1.3 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1339 - Bump prettier from 2.7.1 to 2.8.8 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1357 - Bump [@​types/node](https://togithub.com/types/node) from 18.16.3 to 20.2.3 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1380 - Bump webfactory/ssh-agent from 0.7.0 to 0.8.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1348 - Bump eslint-config-prettier from 8.6.0 to 8.8.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1342 - Bump [@​types/node](https://togithub.com/types/node) from 20.2.3 to 20.2.4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1381 - Bump [@​types/node](https://togithub.com/types/node) from 20.2.4 to 20.2.5 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1383 - Bump [@​types/node](https://togithub.com/types/node) from 20.2.5 to 20.3.1 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1385 - Bump eslint-plugin-jest from 27.2.1 to 27.2.2 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1386 - Bump [@​types/node](https://togithub.com/types/node) from 20.3.1 to 20.3.2 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1387 - Bump [@​types/node](https://togithub.com/types/node) from 20.3.2 to 20.3.3 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1389 - Bump semver from 5.7.1 to 5.7.2 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1396 - Bump tough-cookie from 4.0.0 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1394 - Bump [@​types/node](https://togithub.com/types/node) from 20.3.3 to 20.4.1 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1395 **Full Changelog**: JamesIves/github-pages-deploy-action@v4...v4.4.3 ### [`v4.4.2`](https://togithub.com/JamesIves/github-pages-deploy-action/releases/tag/v4.4.2) [Compare Source](https://togithub.com/JamesIves/github-pages-deploy-action/compare/v4.4.1...v4.4.2) #### What's Changed - Dependency updates **Full Changelog**: JamesIves/github-pages-deploy-action@v4...v4.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SebastianGoeb/chinese-chart). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
andipaetzold
pushed a commit
to andipaetzold/react-firehooks
that referenced
this pull request
Mar 14, 2024
….5.0 (#257) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [JamesIves/github-pages-deploy-action](https://togithub.com/JamesIves/github-pages-deploy-action) | action | minor | `v4.4.3` -> `v4.5.0` | --- ### Release Notes <details> <summary>JamesIves/github-pages-deploy-action (JamesIves/github-pages-deploy-action)</summary> ### [`v4.5.0`](https://togithub.com/JamesIves/github-pages-deploy-action/releases/tag/v4.5.0) [Compare Source](https://togithub.com/JamesIves/github-pages-deploy-action/compare/v4.4.3...v4.5.0) #### What's Changed - The action is now built and run on Node 20. - Bump [@​types/node](https://togithub.com/types/node) from 20.4.1 to 20.4.2 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1399 - Bump eslint-plugin-jest from 27.2.2 to 27.2.3 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1400 - Bump word-wrap from 1.2.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1401 - Bump eslint-config-prettier from 8.8.0 to 8.9.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1405 - Bump [@​types/node](https://togithub.com/types/node) from 20.4.2 to 20.4.9 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1413 - Bump eslint-config-prettier from 8.9.0 to 9.0.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1410 - Upgrade Node for security by [@​nickmccurdy](https://togithub.com/nickmccurdy) in [JamesIves/github-pages-deploy-action#1437 - doc: `.gitignore` matches not being deployed by [@​sgasse](https://togithub.com/sgasse) in [JamesIves/github-pages-deploy-action#1459 - build(deps): bump actions/setup-node from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1467 - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 20.4.9 to 20.9.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1474 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1429 - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 20.9.0 to 20.10.0 by [@​dependabot](https://togithub.com/dependabot) in [JamesIves/github-pages-deploy-action#1479 #### New Contributors - [@​sgasse](https://togithub.com/sgasse) made their first contribution in [JamesIves/github-pages-deploy-action#1459 **Full Changelog**: JamesIves/github-pages-deploy-action@v4.4.3...v4.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/andipaetzold/react-firehooks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Node 16 is dead and we need to upgrade for support and security (OpenSSL is no longer supported). For now I've only touched the dev containers.
Testing Instructions
Opened a Codespace, installed dependencies, and ran package scripts. I can't test
base.Dockerfilebecause I don't have Docker installed.Additional Notes
I noticed you already had #1398. I decided to still make this PR since you haven't updated the dev containers yet, but you might want to wait to release them together.