Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to debug new oracle action version #11067

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Try to debug new oracle action version #11067

merged 4 commits into from
Mar 21, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Mar 21, 2024

Try to debug new oracle setup-java action.

It runs on Java 21 - https://github.com/oracle-actions/setup-java/releases/tag/v1.3.4

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Member Author

koppor commented Mar 21, 2024

This downgrades the action to the last one without requirement to JDK21 (which is unavailable on BuildJet)

@koppor
Copy link
Member Author

koppor commented Mar 21, 2024

Alternatively, we could set JAVA_HOME_21_arm64 in the workflow to the JDK17.

@koppor
Copy link
Member Author

koppor commented Mar 21, 2024

Security: For higher security, we could pin the versions to SHA https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions. - Not sure, how this works with dependabot.

@koppor
Copy link
Member Author

koppor commented Mar 21, 2024

Drawack: We cannot run on ARM64 with that - oracle-actions/setup-java#73

Copy link
Contributor

github-actions bot commented Mar 21, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit bcdf31d Mar 21, 2024
27 checks passed
@Siedlerchr Siedlerchr deleted the koppor-patch-2 branch March 21, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants