Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin min pymatgen version > lobster 5.0/5.1 support #342

Merged
merged 2 commits into from
Oct 25, 2024
Merged

pin min pymatgen version > lobster 5.0/5.1 support #342

merged 2 commits into from
Oct 25, 2024
+23 −1

Conversation

naik-aakash
Copy link
Collaborator

@naik-aakash naik-aakash commented Oct 25, 2024 •
edited
Loading

Closes #336

@naik-aakash
pin min pymatgen version > lobster 5.0/5.1 support

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
affc6f4
@naik-aakash naik-aakash marked this pull request as draft October 25, 2024 16:06
@naik-aakash
add v51 tests
Loading
Loading status checks…
39c17aa
@naik-aakash naik-aakash marked this pull request as ready for review October 25, 2024 16:45
@naik-aakash naik-aakash enabled auto-merge October 25, 2024 16:45
@naik-aakash naik-aakash requested a review from JaGeo October 25, 2024 16:45
@naik-aakash
Copy link
Collaborator Author

Hi Janine, this PR could be merged

@naik-aakash naik-aakash merged commit bcd9b99 into JaGeo:main Oct 25, 2024
24 checks passed
@naik-aakash naik-aakash added the enhancement New feature or request label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaGeo JaGeo

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICOHPLIST.lobster format changed in lobster 5.1.1
2 participants
@naik-aakash @JaGeo